Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pbench Dashboard Doc #3431

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Pbench Dashboard Doc #3431

merged 4 commits into from
Jun 5, 2023

Conversation

MVarshini
Copy link
Contributor

PBENCH-1158

Pbench Dashboard Doc

User guide for Pbench Dashboard

@MVarshini MVarshini self-assigned this May 24, 2023
dbutenhof
dbutenhof requested changes May 24, 2023
View reviewed changes
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great; but while it's a minor point I think that the distinction between the generic term "API" and the specific term "API Key" is important. I made a few other suggestions; but with the "API Key" change I'd be happy to approve.

docs/Dashboard/user_guide.md Outdated Show resolved Hide resolved
docs/Dashboard/user_guide.md Show resolved Hide resolved
webbnh
webbnh previously approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have some suggestions for polishing.

docs/Dashboard/user_guide.md Outdated Show resolved Hide resolved
docs/Dashboard/user_guide.md Outdated Show resolved Hide resolved
docs/Dashboard/user_guide.md Outdated Show resolved Hide resolved
docs/Dashboard/user_guide.md Outdated Show resolved Hide resolved
docs/Dashboard/user_guide.md Outdated Show resolved Hide resolved
dbutenhof
dbutenhof previously approved these changes Jun 2, 2023
View reviewed changes
pravins
pravins previously approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@pravins pravins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

webbnh
webbnh previously approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, you might want to remove these few nits before merging.

docs/Dashboard/user_guide.md Outdated Show resolved Hide resolved
docs/Dashboard/user_guide.md Outdated Show resolved Hide resolved
@MVarshini MVarshini dismissed stale reviews from dbutenhof, webbnh, and pravins via c6374f6 June 5, 2023 09:41
webbnh
webbnh approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dbutenhof dbutenhof merged commit 22ade07 into distributed-system-analysis:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@webbnh webbnh webbnh approved these changes

@pravins pravins pravins left review comments

@vishalvvr vishalvvr Awaiting requested review from vishalvvr

@riya-17 riya-17 Awaiting requested review from riya-17

Assignees

@MVarshini MVarshini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MVarshini @pravins @webbnh @dbutenhof