Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test on jwt exception type instead of string (b0.72 backport of #3417) #3424

Merged
merged 1 commit into from
May 17, 2023

Conversation

ndokos
Copy link
Member

@ndokos ndokos commented May 16, 2023

  • Check jwt exception type instead of string in the unit tests

Jwt exception (specifically jwt.exception.InvalidAudienceError) has changed its string message from Invalid Audience to Audience doesn't match. In the unit test instead of checking the string message check the type of the exception.

…istributed-system-analysis#3417)

* Check jwt exception type instead of string in the unit tests

Jwt exception (specifically jwt.exception.InvalidAudienceError)
has changed its string message from `Invalid Audience` to
`Audience doesn't match`. In the unit test instead of checking
the string message check the type of the exception.
@ndokos ndokos self-assigned this May 16, 2023
@ndokos ndokos requested review from webbnh and npalaska May 16, 2023 23:27
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbutenhof dbutenhof merged commit 8aa8e71 into distributed-system-analysis:b0.72 May 17, 2023
@ndokos ndokos deleted the backport-3417 branch May 19, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants