Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible fixes #3420

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

ndokos
Copy link
Member

@ndokos ndokos commented May 16, 2023

Forward port of #3407 from b0.72.

  • The `ansible.builtin.command' module does not take a warn argument

The argument gives errors now, so delete it.

  • There are now two repos for pbench-agent

The pbench repo contains RPMs for pbench-sysstat and screen (the latter for some distros, mainly RHEL8 - RHEL9 picks up screen from EPEL).

The pbench-<version> repo contains the RPM for the latest release of pbench-agent (and possibly a server RPM although we don't install RPMs for the server: containers have taken over).

Forward port of distributed-system-analysis#3407 from b0.72.

* The `ansible.builtin.command' module does not take a warn argument

The argument gives errors now, so delete it.

* There are now two repos for pbench-agent

The pbench repo contains RPMs for pbench-sysstat and screen (the latter
for *some* distros, mainly RHEL8 - RHEL9 picks up screen from EPEL).

The pbench-<version> repo contains the RPM for the latest release of
pbench-agent (and possibly a server RPM although we don't install RPMs
for the server: containers have taken over).
@ndokos ndokos added bug enhancement Agent Ansible Ansible playbooks for pbench agent installation labels May 16, 2023
@ndokos ndokos self-assigned this May 16, 2023
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me, although I have a pointed question.

Beyond that, I have a comment:

The pbench- repo contains [...]

Is the name of the repo really pbench-? That seems like an awkward choice: the trailing hyphen is easy to overlook, and if we have to convey the name to someone outside the project, it'll take extra text to make sure that they don't "misspell" it. (I know that naming is one of the "hard problems of Computer Science", but perhaps a 2 would be better than a hyphen, if we cannot come up with anything more descriptive.)

@webbnh

This comment was marked as outdated.

@ndokos
Copy link
Member Author

ndokos commented May 16, 2023

See the updated blurb above: Markdown ate the <version> part. This is the workaround for COPR's penchant of deleting previous versions when a new one is added to a repo: we use separate repos.

@ndokos ndokos requested review from vishalvvr and riya-17 May 16, 2023 21:53
Copy link
Member

@vishalvvr vishalvvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbutenhof dbutenhof merged commit e5d4efa into distributed-system-analysis:main May 17, 2023
@ndokos ndokos deleted the ansible-fixes branch June 27, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Ansible Ansible playbooks for pbench agent installation bug enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants