-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible fixes #3420
Ansible fixes #3420
Conversation
Forward port of distributed-system-analysis#3407 from b0.72. * The `ansible.builtin.command' module does not take a warn argument The argument gives errors now, so delete it. * There are now two repos for pbench-agent The pbench repo contains RPMs for pbench-sysstat and screen (the latter for *some* distros, mainly RHEL8 - RHEL9 picks up screen from EPEL). The pbench-<version> repo contains the RPM for the latest release of pbench-agent (and possibly a server RPM although we don't install RPMs for the server: containers have taken over).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me, although I have a pointed question.
Beyond that, I have a comment:
The pbench- repo contains [...]
Is the name of the repo really pbench-
? That seems like an awkward choice: the trailing hyphen is easy to overlook, and if we have to convey the name to someone outside the project, it'll take extra text to make sure that they don't "misspell" it. (I know that naming is one of the "hard problems of Computer Science", but perhaps a 2
would be better than a hyphen, if we cannot come up with anything more descriptive.)
This comment was marked as outdated.
This comment was marked as outdated.
See the updated blurb above: Markdown ate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Forward port of #3407 from b0.72.
The argument gives errors now, so delete it.
The
pbench
repo contains RPMs forpbench-sysstat
andscreen
(the latter for some distros, mainly RHEL8 - RHEL9 picks up screen from EPEL).The
pbench-<version>
repo contains the RPM for the latest release ofpbench-agent
(and possibly a server RPM although we don't install RPMs for the server: containers have taken over).