Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire the previous containerized Agent example from contrib #3384

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented Apr 14, 2023

The recently added pbench and pbench_demo files in contrib/containerized-pbench/ now encompass the previous example which was there. This PR removes the files associated with the previous example and updates the README.md file.

(Also, my IDE has acquired a new bash linter, and so I made some small tweaks to the pbench_demo to shut it up.)

dbutenhof
dbutenhof previously approved these changes Apr 14, 2023
contrib/containerized-pbench/pbench_demo Show resolved Hide resolved
@webbnh webbnh self-assigned this Apr 17, 2023
@webbnh webbnh added Agent Documentation Contrib Containerization Of and relating to the process of setting up and maintaining container images labels Apr 17, 2023
@webbnh webbnh added this to the v0.73 milestone Apr 17, 2023
dbutenhof
dbutenhof previously approved these changes Apr 17, 2023
@webbnh
Copy link
Member Author

webbnh commented Apr 19, 2023

The changes to #3383 collided with the changes I made in response to Dave's comment above, so I removed them from my branch during the rebase, which, interestingly, did not revoke Dave's approval [yes, it did, but the big green checkmark still shows by Dave's entry ah, the wonders of revisionist history...].

(But, Smee hasn't poked Mr. Jenkins about this, yet...I'm hoping that posting this comment will make that happen....)

@dbutenhof
Copy link
Member

The changes to #3383 collided with the changes I made in response to Dave's comment above, so I removed them from my branch during the rebase, which, interestingly, did not revoke Dave's approval [yes, it did, but the big green checkmark still shows by Dave's entry ah, the wonders of revisionist history...].

(But, Smee hasn't poked Mr. Jenkins about this, yet...I'm hoping that posting this comment will make that happen....)

The bad news is ... it doesn't really matter much at this time.

Someone has completely removed the npmjs.com package for keycloak-masthead, which is a dependency of the keycloak-js package we use. All our builds are failing and will continue to fail until either keycloak-js stops depending on it, keycloak-masthead is restored, or we stop depending on keycloak-js (which I believe we really don't want to do).

So for now, Jenkins builds are gone. 😦

@webbnh
Copy link
Member Author

webbnh commented Apr 19, 2023

Someone has completely removed the npmjs.com package for keycloak-masthead, which is a dependency of the keycloak-js package we use. All our builds are failing and will continue to fail until either keycloak-js stops depending on it, keycloak-masthead is restored, or we stop depending on keycloak-js (which I believe we really don't want to do).

The keycloak/keycloak-ui repo (which was archived today) says

The keycloak-ui repo has been merged into the /js directory of the Keycloak repository. Please open any new issues and PRs on that repository.

So...hopefully, we're just in some sort of transition and we're waiting for a build or a cache or something to flush....

@webbnh
Copy link
Member Author

webbnh commented Apr 19, 2023

According to npmjs.com, the keycloak-js package was updated 6 hours ago to v21.1.0 (from v21.0.2).

@dbutenhof
Copy link
Member

According to npmjs.com, the keycloak-js package was updated 6 hours ago to v21.1.0 (from v21.0.2).

Yes, that's the broken package. 21.1.0-1 is now up with a fix, even though the associated PR #19811 isn't merged yet. If I'd just been a minute slower in working around it, everything would have been fine. (Sigh.) 😆

@webbnh webbnh merged commit f3bea9f into distributed-system-analysis:main Apr 20, 2023
@webbnh webbnh deleted the update-contrib branch April 20, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Containerization Of and relating to the process of setting up and maintaining container images Contrib Documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants