Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate mistakenly deleted test #3379

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

ndokos
Copy link
Member

@ndokos ndokos commented Apr 13, 2023

No description provided.

@ndokos ndokos self-assigned this Apr 13, 2023
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing something in one PR and restoring it in another somewhat complicates the review flow, and I'm too lazy right now to go back and check this against the original, so I'm just rubber-stamping on the assumption it's a simple cut and paste. 😆

@ndokos
Copy link
Member Author

ndokos commented Apr 13, 2023

I understand and all I can say is Mea culpa. It is just a cut-and-paste and since the change was already merged (and mostly correct I think except for this mistake), adding it back in a separate PR seemed the simplest solution.

@ndokos ndokos requested a review from webbnh April 13, 2023 15:33
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing something in one PR and restoring it in another somewhat complicates the review flow

I understand and all I can say is Mea culpa.

Well, better review would have caught this prior to the back-and-forth port.... 🤷

@ndokos ndokos merged commit 5fa129e into distributed-system-analysis:main Apr 19, 2023
@ndokos ndokos deleted the deleted-test branch April 19, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants