Api #3367
Merged
Api #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
added
Server
Dashboard
dbutenhof
requested review from
MVarshini,
webbnh,
npalaska,
vishalvvr and
siddardh-ra
webbnh
previously approved these changes
Mar 31, 2023
|
Sigh; and, once again, I had to nudge Mr Jenkins to wake him up because Mr Smee slept through his alarm again ... |
PBENCH-1119
With the REST-ification of the API, only a few of the APIs can still be called
using the simplistic `{name: uri}` list, because URI parameters are needed and
are no longer at the end of the URI: for example,
`/api/v1/datasets/{dataset}/metadata`.
The UI now has the `uriTemplate` method to help expand the `"uri"` template
objects. Complete the transition by updating the remaining UI references and
dropping the `api` object entirely.
(How'd that happen?)
npalaska
approved these changes
Apr 4, 2023
ndokos
reviewed
Apr 4, 2023
| @@ -1,13 +1,15 @@ | |||
| import * as TYPES from "./types"; | |||
|
|
|||
| import API from "../utils/axiosInstance"; | |||
| import { uriTemplate } from "utils/helper"; | |||
There was a problem hiding this comment.
Nit: overviewActions.js and tableOfContentActions.js import from ../utils/helper (although findNoOfDays is imported from utils/dateFunctions in overviewActions.js). Assuming that they are equivalent, maybe we should go with a single idiom in all cases.
There was a problem hiding this comment.
It's a good point, and I'm not quite sure how this ended up that way because I'm usually not inclined to depend on the default root. (And it confuses vscode, too.)
ndokos
reviewed
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1119
With the REST-ification of the API, only a few of the APIs can still be called using the simplistic
"api": {name: string, ...}list, because URI parameters are generally needed and are no longer at the end of the URI: for example,/api/v1/datasets/{dataset}/metadata.The UI now has the
uriTemplatemethod to help expand the"uri"template objects. Complete the transition by updating the remaining UI references and dropping theapiobject entirely.This was immediately motivated by Webb's comment on my API documentation PR that it was odd I was documenting that the
apiobject inendpointsis "mostly obsolete"; better to simply remove it and move on.