Move set-expiration of Server container to a conditional pipeline stage (b0.72 backport)
#3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The container images built by the CI are pushed to an external registry and set with an expiration date for auto-deletion. This is valuable for transient images which are built for PRs, but it is unfortunate for images built from branches in the main repo, such as release branches and `main`. This change moves the setting of the expiration date to its own pipeline stage which is executed only for PRs, so that branch builds will not expire. PBENCH-1113
dbutenhof
approved these changes
Mar 22, 2023
portante
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container images built by the CI are pushed to an external registry and set with an expiration date for auto-deletion. This is valuable for transient images which are built for PRs, but it is unfortunate for images built from branches in the main repo, such as release branches and
main. This change moves the setting of the expiration date to its own pipeline stage which is executed only for PRs, so that branch builds will not expire.PBENCH-1113