Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup page Bugs #3324

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Signup page Bugs #3324

merged 3 commits into from
Mar 13, 2023

Conversation

MVarshini
Copy link
Contributor

PBENCH-1096

Signup page Bugs

  • Make the scroll visible on sign up form
  • Show password for both "Password" and "Confirm password" fields
  • Include "Sign up" option in the Login form

@MVarshini MVarshini requested a review from siddardh-ra March 8, 2023 13:30
@MVarshini MVarshini self-assigned this Mar 8, 2023
@MVarshini MVarshini force-pushed the PBENCH-1096 branch 2 times, most recently from 40e6119 to b24e8d4 Compare March 8, 2023 14:28
dbutenhof
dbutenhof previously approved these changes Mar 8, 2023
View reviewed changes
dashboard/src/modules/components/AuthComponent/index.less Outdated Show resolved Hide resolved
webbnh
webbnh previously approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would remove the commented-out code.

dashboard/src/modules/components/AuthComponent/index.less Outdated Show resolved Hide resolved
@portante portante added this to the v0.72 milestone Mar 10, 2023
@portante portante added bug Dashboard Of and relating to the Dashboard GUI labels Mar 10, 2023
@MVarshini MVarshini dismissed stale reviews from webbnh and dbutenhof via eed0585 March 13, 2023 10:46
@dbutenhof dbutenhof merged commit 87d739a into distributed-system-analysis:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@siddardh-ra siddardh-ra siddardh-ra approved these changes

@webbnh webbnh webbnh left review comments

Assignees

@MVarshini MVarshini

Labels
bug Dashboard Of and relating to the Dashboard GUI
Projects
None yet
Milestone
v0.72
Development

Successfully merging this pull request may close these issues.
5 participants
@MVarshini @webbnh @siddardh-ra @dbutenhof @portante