-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an explicit ENTRYPOINT to the Agent "all" containers #3320
Add an explicit ENTRYPOINT to the Agent "all" containers #3320
Conversation
082583d
to
7b79be7
Compare
I think the wrinkles are all smoothed out and this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, even really nice, but simply looking at the files doesn't make it immediately obvious how to use them in combination. It'd be nice to update (or maybe even replace) contrib/containerized-pbench/README.md
...
And does the simpler example
script ecosystem Pete set up in there still make sense? It'd be nice for the documentation to set some context.
This PR is very much an example of "run it up the flag pole and see who salutes". I would like to see the As far as I'm concerned, we don't need to merge the If people like the I can update the |
Well, I'd like to see this |
My thoughts exactly. 😇 (This is why the |
7b79be7
to
63ee73e
Compare
Converting to draft while I work the wrinkles out of the new approach. |
63ee73e
to
541aea8
Compare
541aea8
to
90f985d
Compare
90f985d
to
19ed28e
Compare
OK, I've reworked this change (and updated the PR): |
OK, this is now ready to merge...if I could get one more round of approvals, please. |
The Agent commands require the environment which the
agent/profile
script sets up. This script is normally run automatically when a user logs in by virtue of a symbolic link in/etc/profile.d
; however, when a user invokes containerized Agent commands, although the profile script exists inside the container, there is no login performed, and so the script isn't run...and it is cumbersome to cause it to run inside the container environment in conjunction with running a pbench command (the easiest approach is to create a script (seecontrib/containerized-pbench/README.md
), but the user has to map that into the container in order to use it; otherwise, the user has to run an interactive shell inside the container, which is not much better).This change provides a little script which
source
's the Agent profile script and thenexec
's the requested command inside the container, and makes use of it as the default entrypoint for the Agent "all" containers. This enables users to use a command line something likeThis PR makes the following changes:
This PR also includes two new files in
contrib/containerized-pbench
:pbench
command script which wraps the container invocation and provides some helpful defaults; and,These last two files don't need to be merged into the repo -- they are mostly provided as "functional documentation" showing how this change is useful. However, they do make it easy to run Agent commands, and they work without having to install the Agent.