Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct abort method #3130

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Use the correct abort method #3130

merged 1 commit into from
Dec 23, 2022

Conversation

portante
Copy link
Member

No description provided.

@portante portante added Server API Of and relating to application programming interfaces to services and functions Users Of and relating to working with users. labels Dec 22, 2022
@portante portante added this to the v0.72 milestone Dec 22, 2022
@portante portante self-assigned this Dec 22, 2022
This was referenced Dec 22, 2022
Merged
Merged
dbutenhof
dbutenhof approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really use the APIAbort exception to defer the abort to _dispatch so we're consistent. We still have the user API classes that don't extend ApiBase, unfortunately, but they'll be gone soon. (I fixed PUT, and I'll retain that part of the PR along with the error-case functional tests when I can rebase on top of your NGINX fix.)

So I'll approve this without a lot of excitement; but it is an immediate fix for the namespace mismatch, and we still have the user APIs... and the message example is probably a nice touch.

@portante portante mentioned this pull request Dec 23, 2022
Open
@portante portante merged commit 9853fbb into distributed-system-analysis:main Dec 23, 2022
@portante
Copy link
Member Author

We should really use the APIAbort exception to defer the abort to _dispatch so we're consistent. We still have the user API classes that don't extend ApiBase, unfortunately, but they'll be gone soon. (I fixed PUT, and I'll retain that part of the PR along with the error-case functional tests when I can rebase on top of your NGINX fix.)

So I'll approve this without a lot of excitement; but it is an immediate fix for the namespace mismatch, and we still have the user APIs... and the message example is probably a nice touch.

I filed issue #3137 to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@siddardh-ra siddardh-ra siddardh-ra approved these changes

@riya-17 riya-17 riya-17 approved these changes

@npalaska npalaska Awaiting requested review from npalaska

Assignees

@portante portante

Labels
API Of and relating to application programming interfaces to services and functions Server Users Of and relating to working with users.
Projects
None yet
Milestone
v0.72
Development

Successfully merging this pull request may close these issues.
4 participants
@portante @riya-17 @siddardh-ra @dbutenhof