-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building Agent containers to the CI #3109
Add support for building Agent containers to the CI #3109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You asked for review, but it's Draft: so a few comments but no cookie.
dec5686
to
259a8e2
Compare
bfe23fe
to
ccbde59
Compare
ccbde59
to
f6b2c23
Compare
Ready for review, at last. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to know why we have to use the internal registry for container images build for PRs when there is not publishing restriction.
f6b2c23
to
fc0cf76
Compare
fc0cf76
to
ba4dc1e
Compare
This PR adds support to the CI for building a single set of Agent containers suitable for running functional tests.
The CI pipeline builds a full set of Agent containers (
base
,tools
,tool-meister
,tool-data-sink
,workloads
, andall
) for a single distro (currently Fedora-36) and pushes them to the container registry. For PR builds, it pushes them to the internal registry; for branch builds (likemain
), it pushes them to the external registry.Details:
TAG_TYPES
list)rename the local references of
PB_SERVER_IMAGE_TAG
toPB_IMAGE_TAG
so it can be used for both the Server and Agent container images; definePB_SERVER_IMAGE_TAG
to the value ofPB_IMAGE_TAG
in the stages which need it; use a better idiom to generate its valuePBENCH-332