Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak the help texts for pbench-tool-meister-start and pbench-fio #3002

Merged
merged 5 commits into from
Sep 14, 2022
Merged

Tweak the help texts for pbench-tool-meister-start and pbench-fio #3002

merged 5 commits into from
Sep 14, 2022

Conversation

webbnh
Copy link
Member

@webbnh webbnh commented Sep 13, 2022

Enhance the pbench-tool-meister-start --redis-server help text.

PBENCH-238
Fixes #2163

Correct the pbench-fio -s help text description.

PBENCH-756

@webbnh
Tweak the help text in two commands
a8c1df2 
Enhance the pbench-tool-meister-start --redis-server help text.

PBENCH-238
Fixes distributed-system-analysis#2163

Correct the pbench-fio -s help text description.

PBENCH-756
@webbnh webbnh added bug Agent Documentation fio pbench-fio benchmark related tools Of and related to the operation and behavior of various tools (iostat, sar, etc.) Tool Meister Of and relating to the Tool Meister sub-system CLI Of and relating to the CLI interface to pbench labels Sep 13, 2022
@webbnh webbnh added this to the v0.72 milestone Sep 13, 2022
@webbnh webbnh self-assigned this Sep 13, 2022
portante
portante requested changes Sep 13, 2022
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tool Meister start change looks good, but I think we need to add some additional clarification of the exact behavior of the pbench-fio -s/--file-size option.

agent/bench-scripts/pbench-fio Outdated Show resolved Hide resolved
dbutenhof
dbutenhof reviewed Sep 13, 2022
View reviewed changes
agent/bench-scripts/pbench-fio Outdated Show resolved Hide resolved
lib/pbench/agent/tool_meister_start.py Outdated Show resolved Hide resolved
portante
portante previously approved these changes Sep 14, 2022
View reviewed changes
portante
portante previously approved these changes Sep 14, 2022
View reviewed changes
@webbnh webbnh requested a review from dbutenhof September 14, 2022 17:31
@dbutenhof dbutenhof merged commit bacdd93 into distributed-system-analysis:main Sep 14, 2022
@webbnh webbnh deleted the help-text-fixes branch September 14, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbutenhof dbutenhof dbutenhof approved these changes

@portante portante portante approved these changes

Assignees

@webbnh webbnh

Labels
Agent bug CLI Of and relating to the CLI interface to pbench Documentation fio pbench-fio benchmark related Tool Meister Of and relating to the Tool Meister sub-system tools Of and related to the operation and behavior of various tools (iostat, sar, etc.)
Projects
None yet
Milestone
v0.72
3 participants
@webbnh @portante @dbutenhof