Bugs in Dashboard #2931
Merged
Bugs in Dashboard #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
reviewed
Jun 30, 2022
dbutenhof
reviewed
Jul 1, 2022
There was a problem hiding this comment.
Please let's not link PRs to Epics or Features in Jira! We should be linking PRs to stories (or bugs) where they're simple, or to sub-tasks where a story/bug requires multiple PRs.
This seems to be several bug/story issues under the PBENCH-86 epic.
It's not necessarily bad to link a PR to multiple simple issues, as long as they're closely related, but in general small focused PRs dealing with a single issue are easier to review.
webbnh
approved these changes
Jul 1, 2022
portante
approved these changes
Jul 3, 2022
dbutenhof
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-86
User management in Dashboard
Bugs