Remove wayward "shbangs" in Python 3 library files

[portante]

And we also remove the unnecessary cli/getconf.py file.

This work was identified while reviewing PR #2901.

[webbnh]

I guess I have no problem with this, but a quick search suggests that we have 69 such files...why do we address only five of them here?

And, why is removing the line (as opposed to setting it to something "standard") the proper fix?

[dbutenhof]

I guess I have no problem with this, but a quick search suggests that we have 69 such files...why do we address only five of them here?

And, why is removing the line (as opposed to setting it to something "standard") the proper fix?

These are all I find searching from lib/pbench; what are you finding?

These are library modules never executed directly by the shell, and the bash wrappers (either direct click wrappers or static wrappers ala agent/util-scripts/pbench-tool-meister-start) are properly shebanged.

[webbnh]

These are library modules never executed directly by the shell

Ah! Perhaps that's the answer.

These are all I find searching from lib/pbench; what are you finding?

Aside from a few in server/bin there are a bunch in each of agent/*-scripts and a few other odds and ends.

[webbnh]

And, FWIW, here are the shbangs that I found:

   1 #!/bin/env python
   5 #!/usr/bin/python
   1 #! /usr/bin/env python
  55 #!/usr/bin/env python

So, we're about 90% consistent....

[ndokos]

The ones under /opt/pbench-agent/{bin,tool-scripts,util-scripts} are properly "mangled" when the RPM is created: the mangling tool seems to handle bin-type directories, but it leaves /opt/pbench-agent/lib alone: it doesn't touch those. That is not to say that we should not be consistent of course.

[webbnh]

The ones under /opt/pbench-agent/{bin,tool-scripts,util-scripts} are properly "mangled" when the RPM is created: the mangling tool seems to handle bin-type directories, but it leaves /opt/pbench-agent/lib alone: it doesn't touch those.

I suspect that it is keying off the eXecute bit on the file and that the directory has nothing to do with it.

If that's the case, then we missed one -- agent/stockpile/roles/openstack_common/files/openstack-config-parser.py -- but perhaps that will be addressed by a separate effort....