-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numactl
RPM requirement
#2879
Conversation
Both the `pbench-uperf` and `pbench-linpack` commands offer interfaces that rely on `numactl`.
@ndokos asked elsewhere: "Why not modify The answer is that those benchmark convenience scripts are not tools. They are part of the interface provided by the If we take the logic that we are applying to tools, that is that the dependencies for tools are not applied to the pbench-agent RPM, then the pbench-agent RPM would have NO dependencies at all. Further, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the Fedora 36 changes from this PR.
But one could argue that the |
BTW: While using the branch name to link to Jira clearly works, it also means the final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I am not convinced of the Jira integration yet. Being able to search in Jira using the GitHub ID is sufficient. No need to litter GitHub with Jira references that nobody outside Red Hat can access. |
Both the
pbench-uperf
andpbench-linpack
commands offer interfaces that rely onnumactl
.