Delete deprecated bench-scripts from agent Makefile #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
previously approved these changes
Apr 29, 2022
There was a problem hiding this comment.
If you don't mind a little feature creep, pyproject.toml needs updating, too, for a similar reason. (The references to binary-search.py and profile-builder.py should be removed from Black's exclusions list, and dbench-postprocess should be removed from the inclusion list.)
dbutenhof
previously approved these changes
Apr 29, 2022
|
@webbnh: I don't mind the feature creep but |
|
I'll defer to @portante.... 😉 |
portante
previously approved these changes
Apr 29, 2022
|
I pushed the changes above (and more) and I'll wait for @portante's approval (which came while I was typing...) |
Fixes distributed-system-analysis#2801 PR distributed-system-analysis#2782 deleted deprecated bench scripts from the tree, but did not delete them from the Makefile. Additional problems were uncovered in code review: - pyproject.toml contained a couple of references to no-longer-existing files and a reference to dbench-postprocess. - dbench-postprocess is no longer necessary and is deleted (both the "real" version and the mocked test version). - pbench-agent-default.cfg still contained references to the deleted bench-scripts, so it is cleaned up. docs/pbench-agent.org still mentions dbench (and maybe other deleted bench-scripts) but I declared it out of scope for this PR. We'll take care of it in the documentation cleanup.
|
See also PR #2803. |
portante
approved these changes
Apr 29, 2022
portante
added
packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2801
PR #2782 deleted deprecated bench scripts from the tree, but did
not delete them from the Makefile.