Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tag of the image that pbench_demo uses for b0.72 #3445

Closed
ndokos opened this issue May 31, 2023 · 1 comment
Closed

Fix the tag of the image that pbench_demo uses for b0.72 #3445

ndokos opened this issue May 31, 2023 · 1 comment
Assignees
@ndokos
Labels
Agent Containerization Of and relating to the process of setting up and maintaining container images
Milestone
v0.72

Comments

@ndokos
Copy link
Member

ndokos commented May 31, 2023

It should use the image tagged b0.72 rather than main: the latter image does not include pbench-generate-token which the script currently assumes is present.
@ndokos ndokos added Agent Containerization Of and relating to the process of setting up and maintaining container images labels May 31, 2023
@ndokos ndokos added this to the v0.72 milestone May 31, 2023
@ndokos ndokos self-assigned this May 31, 2023
ndokos added a commit to ndokos/pbench that referenced this issue May 31, 2023
@ndokos
Fix the image tag
67e3de1 
Fixes distributed-system-analysis#3445

pbench_demo uses an image downloaded from Quay.io. It assumes that the
image will contain `pbench-generate-token` which is available
currently but it is deprecated and will not be available in the
future.  In particular, the specified image
`quay.io/pbench/pbench-agent-all-fedora-36:all` does *not* contain the
script. We need to make use
`quay.io/pbench/pbench-agent-all-fedora-36:b0.72` instead.

PBENCH-1129
@ndokos ndokos mentioned this issue May 31, 2023
Merged
ndokos added a commit that referenced this issue Jun 1, 2023
@ndokos
Fix the image tag (#3446)
d021d23 
Fixes #3445

pbench_demo uses an image downloaded from Quay.io. It assumes that the
image will contain `pbench-generate-token` which is available
currently but it is deprecated and will not be available in the
future.  In particular, the specified image
`quay.io/pbench/pbench-agent-all-fedora-36:all` does *not* contain the
script. We need to make use
`quay.io/pbench/pbench-agent-all-fedora-36:b0.72` instead.

PBENCH-1129
@ndokos
Copy link
Member Author

ndokos commented Jun 15, 2023

Fixed by #3446

@ndokos ndokos closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndokos ndokos

Labels
Agent Containerization Of and relating to the process of setting up and maintaining container images
Projects
None yet
Milestone
v0.72
Development

No branches or pull requests
1 participant
@ndokos