Review comments

distributed-system-analysis · Jun 16, 2023 · dc506c5 · dc506c5
1 parent 13ad2d2
commit dc506c5
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/lib/pbench/client/__init__.py b/lib/pbench/client/__init__.py
@@ -49,11 +49,11 @@ class API(Enum):
     DATASETS_VALUES = "datasets_values"
     ENDPOINTS = "endpoints"
     KEY = "key"
-    QUISBY = "quisby"
     RELAY = "relay"
     SERVER_AUDIT = "server_audit"
     SERVER_SETTINGS = "server_settings"
     UPLOAD = "upload"
+    VISUALIZE = "visualize"
 
 
 class PbenchServerClient:

diff --git a/lib/pbench/server/api/__init__.py b/lib/pbench/server/api/__init__.py
@@ -137,7 +137,6 @@ def register_endpoints(api: Api, app: Flask, config: PbenchServerConfig):
     api.add_resource(
         Visualize,
         f"{base_uri}/visualize/<string:dataset>",
-        f"{base_uri}/visualize/<string:dataset>/",
         endpoint="visualize",
         resource_class_args=(config,),
     )

diff --git a/lib/pbench/server/api/resources/visualize.py b/lib/pbench/server/api/resources/visualize.py
@@ -94,5 +94,5 @@ def _get(
 
         else:
             raise APIInternalError(
-                f"Quisby processing failure. Exception : { get_quisby_data['exception']}"
+                f"Quisby processing failure. Exception: {get_quisby_data['exception']}"
             )
diff --git a/lib/pbench/test/unit/server/test_visualize.py b/lib/pbench/test/unit/server/test_visualize.py
@@ -33,7 +33,7 @@ def query_api(
                 dataset_id = dataset  # Allow passing deliberately bad value
             headers = {"authorization": f"bearer {get_token_func(user)}"}
             response = client.get(
-                f"{server_config.rest_uri}/visualize/{dataset_id}/",
+                f"{server_config.rest_uri}/visualize/{dataset_id}",
                 headers=headers,
             )
             assert response.status_code == expected_status