Skip to content
This repository has been archived by the owner on Feb 27, 2021. It is now read-only.

[requires.io] dependency update on master branch #610

Closed
wants to merge 4 commits into from

Conversation

Phyks
Copy link
Member

@Phyks Phyks commented Feb 19, 2019

No description provided.

@Phyks
Copy link
Member Author

Phyks commented Feb 20, 2019

@wetneb one test is failing with this PR. This is a bit weird, it does not seem to be due to the updates though, at first sight.

html5lib should not have any breaking changes https://github.com/html5lib/html5lib-python/blob/master/CHANGES.rst#101.

pytest should not either https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst#pytest-430-2019-02-16

Is there a specific reason for pinning these to these specific versions (pytest in particular) in the requirements.txt file? If not, I'll have a deeper look and try to make this one mergeable and implement frozen requirements for the future.

@wetneb
Copy link
Member

wetneb commented Feb 20, 2019

I pinned pytest for compatibility with its django plugin I think, but it could also have been for a coverage plugin (pytest-cov) that I didn't end up using. But I suspect the failure could be linked to that (different behaviour of fixtures and test set ups?).

For htmllib I can't remember, that was years ago - it's probably safe to upgrade (it's only used for the tests anyway, so as long as the current tests pass it's fairly safe).

@Phyks
Copy link
Member Author

Phyks commented Feb 21, 2019

I checked and merging the first commit, updating html5lib is definitely fine.

The tests are failing due to pytest update, I'll investigate this.

@Phyks
Copy link
Member Author

Phyks commented Feb 21, 2019

@wetneb Ok, I managed to reduce a lot the scope of the issue. I would probably need a second look for fixing this though :/

Minimal command to reproduce is:

python -m pytest -x deposit/osf/tests.py papers/tests/test_models.py -k 'test_create_by_identifier_valid_paper or test_get_form_initial_data'

And this happens for Pytest >= 4.2.0, so it is due to a change in 4.2.0.

I traced back the issue to be coming from this line in ProtocolTest. Removing the @pytest.mark.usefixtures removes the issue.

Given the changelog, I guess this is linked to pytest-dev/pytest#517 / pytest-dev/pytest#3094, but I'm a bit stuck at this point :/

@Phyks Phyks closed this Apr 11, 2019
@Phyks Phyks deleted the requires-io-master branch April 11, 2019 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants