Add TS compatibility for DiscussionEmbedConfig interface for SSO #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjtang
changed the title
This was referenced Sep 7, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change includes typing for the DiscussionEmbedConfig interface to handle SSO properties.
Motivation and Context
The DiscussionEmbed component's SSO capabilities should be compatible with TypeScript.
How Has This Been Tested?
Tested on a Disqus-React repo running TS locally. Also tested with a Disqus publisher's config that is running TS (details in DSQDEV-2316). Previously, there were TS error messages being generated in the pub's config, but after this change, the error messages were no longer appearing.
Screenshots (if appropriate):
Types of changes
Checklist: