Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to have fatal errors lead to the test process ending #653

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Attempt to have fatal errors lead to the test process ending #653

wants to merge 1 commit into from
+27 −12

Conversation

Baccata
Copy link
Contributor

@Baccata Baccata commented Apr 24, 2023

Attempt at addressing #651

Just a quick POC to see whether something can be done.

@kubukoz
Copy link
Member

kubukoz commented Apr 24, 2023

It seems to work fine when I run test, but in testOnly with just the weaver suite it still hangs. It can be cancelled with ctrl+C though.

@Baccata
Copy link
Contributor Author

Baccata commented Apr 24, 2023

but in testOnly with just the weaver suite it still hangs. It can be cancelled with ctrl+C though.

How did you test, out of curiosity ?

@kubukoz
Copy link
Member

kubukoz commented Apr 24, 2023

oof I thought I'd linked the full repro in the original ticket...

https://github.com/kubukoz/demos/tree/sbt-weaver-hang

  1. test (runs weaver, munit, scalatest)
  2. testOnly DemoTestWeaver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Baccata @kubukoz