-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep protocol in smithy4s->http4s URI conversion #1233
Conversation
Something else I'm wondering about: val uriScheme = uri.scheme match {
case Some(Uri.Scheme.http) => Smithy4sHttpUriScheme.Http
case _ => Smithy4sHttpUriScheme.Https
} this would make |
I'd also do the opposite, match if we have |
0ae3cd9
to
34dc62f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Closes #1232