Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep protocol in smithy4s->http4s URI conversion #1233

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Oct 2, 2023

Closes #1232

@kubukoz kubukoz marked this pull request as ready for review October 2, 2023 19:10
@kubukoz kubukoz added this to the 0.18.0 milestone Oct 2, 2023
@kubukoz
Copy link
Member Author

kubukoz commented Oct 2, 2023

Something else I'm wondering about:

    val uriScheme = uri.scheme match {
      case Some(Uri.Scheme.http) => Smithy4sHttpUriScheme.Http
      case _                     => Smithy4sHttpUriScheme.Https
    }

this would make https the default scheme. I'm not sure we're ready for such a revolution... but it certainly would be worth at least documenting somewhere.

@daddykotex
Copy link
Contributor

Something else I'm wondering about:

    val uriScheme = uri.scheme match {
      case Some(Uri.Scheme.http) => Smithy4sHttpUriScheme.Http
      case _                     => Smithy4sHttpUriScheme.Https
    }

this would make https the default scheme. I'm not sure we're ready for such a revolution... but it certainly would be worth at least documenting somewhere.

I'd also do the opposite, match if we have Some(https) and use http otherwise

@kubukoz kubukoz force-pushed the add-http-protocol branch from 0ae3cd9 to 34dc62f Compare October 3, 2023 15:38
@kubukoz kubukoz changed the base branch from series/0.18 to misc-polish October 3, 2023 15:38
Copy link
Contributor

@daddykotex daddykotex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@Baccata Baccata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@Baccata Baccata merged commit af517d7 into misc-polish Oct 4, 2023
@Baccata Baccata deleted the add-http-protocol branch October 4, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behavior in http4s URIs
3 participants