Replace os.Chdir logic in ISO9660 with absolute paths to allow for concurrent use #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have a use case where I create multiple ISO files concurrently with different contents and names.
The
os.Chdir()
call changes the working dir for the entire app. Having multiple go routines that call the function does end up in a race condition which has the correct working dir.This patch uses absolute paths and does not rely on the working directory to be changed.
Thanks for maintaining the package!