Fix Github Actions workflow for publish_docker #303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR fixes 2 issues with the current workflow:
new_version
as output (src: https://github.com/discourse/publish-rubygems-action/blob/v2/entrypoint.sh#L25) but we were checking onnew_version_published
. This meant the if statement for thepublish_docker
job was always false.It's not that easy to test, but I tested this out on my fork (with some workarounds) and the
publish_docker
job triggered now successfully: https://github.com/pcallewaert/prometheus_exporter/actions/runs/7637020510This should fix #301