Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Actions workflow for publish_docker #303

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

pcallewaert
Copy link
Contributor

@pcallewaert pcallewaert commented Jan 24, 2024

Hi 👋

This PR fixes 2 issues with the current workflow:

It's not that easy to test, but I tested this out on my fork (with some workarounds) and the publish_docker job triggered now successfully: https://github.com/pcallewaert/prometheus_exporter/actions/runs/7637020510

This should fix #301

@sosedoff
Copy link
Contributor

Interesting. When i worked on the release flow i also used my own fork for testing, and it was working initially. Suspecting there were slight changes in the action that we missed since no new versions of this gem were published for a while (about a year?).

@SamSaffron
Copy link
Member

I am more than happy to try it out!

@SamSaffron SamSaffron merged commit 239e2c6 into discourse:main Jan 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Docker image not built for latest release
3 participants