FEATURE: Warn when not using a number for lastId #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By mistake we set
lastId = "0"
which was silently changed to-1
which took longer than it should have done to track down.As an aside:
I tried to add a JS spec but I got
on my machine and when using docker. I'm guessing this is something to do with bazelbuild/rules_closure#353, maybe it is worth looking at headless broswer alternatives to phantomjs?