Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less reliance on global_id #188

Closed
wants to merge 6 commits into from
Closed

Less reliance on global_id #188

wants to merge 6 commits into from

Commits on Dec 3, 2018

  1. Stops reporting the global_id to Javascript subscribers

    There's nothing useful they can do with it anyway.
    benlangfeld committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    8d21a7f View commit details
    Browse the repository at this point in the history
  2. Stops providing usable global_id unless messages come from global b…

    …acklog
    
    Will now report -1 any time a message comes directly from a specific channel. It is not possible for an arbitrary backend implementation to efficiently provide the `global_id` of messages fetched from channel-specific storage mechanisms.
    benlangfeld committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    038db84 View commit details
    Browse the repository at this point in the history
  3. Eliminates some message ID math

    Also probably improves performance by fetching full backlogs less often.
    benlangfeld committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    dd263cc View commit details
    Browse the repository at this point in the history
  4. Only support subscribing from the point of a message already published

    Subscribing from some future point is unnecessary and heavy to implement. See ae0d7cd#commitcomment-31541983
    benlangfeld committed Dec 3, 2018
    1 Configuration menu
    Copy the full SHA
    a2e87d0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2d59bcf View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Raise an error when subscribing in the future

    When client code tries to subscribe to a channel using a `last_id` that doesn't exist on that channel, we raise an exception.
    
    See ae0d7cd#commitcomment-31544627 for details.
    benlangfeld committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    e62f532 View commit details
    Browse the repository at this point in the history