FEATURE: Support subcategory paths in custom route setting #60
Conversation
brrusselburg
force-pushed
the
br/subcats
branch
from
f9c3851 to
33d524d
Compare
brrusselburg
force-pushed
the
br/subcats
branch
from
6666b3e to
76e0463
Compare
brrusselburg
changed the title
brrusselburg
changed the title
brrusselburg
force-pushed
the
br/subcats
branch
from
a6a67c4 to
e31c523
Compare
brrusselburg
force-pushed
the
br/subcats
branch
3 times, most recently
from
6673b9e to
3117dd2
Compare
brrusselburg
force-pushed
the
br/subcats
branch
from
3117dd2 to
c8eb8b1
Compare
| // check if current page is subcategory | ||
| // -- is category | ||
| // -- does not have children itself | ||
| // -- has a parent category | ||
| if ( | ||
| !!this.category && | ||
| !this.category.has_children && | ||
| !!this.category.parent_category_id | ||
| ) { | ||
| subcategory = categorySlug; | ||
| parentCategory = category.ancestors[0].slug; | ||
| } | ||
|
|
||
| if ( | ||
| selectedRoutes.includes(currentRouteName) || | ||
| selectedRoutes.includes(`c/${categorySlug}`) || | ||
| selectedRoutes.includes(`c/${parentCategory}/${subcategory}`) || | ||
| selectedRoutes.includes(`tag/${tagId}`) | ||
| ) { |
There was a problem hiding this comment.
I might be missing something but it feels like you could do: selectedRoutes.includes(this.category.path) and remove a lot of logic of this codeblock.
There was a problem hiding this comment.
I'll give that a shot! No reason, I just wanted to make it as specific as possible just in case.
|
@jjaffeux I think the edit would be a breaking change for a lot of people, after trying it out. The difference would be that people need the exact syntax of the path, for ex: |
I see thanks for trying |
| ### Blocks from other plugins | ||
|
|
||
| The Discourse Calendar plugin comes with a block called `upcoming-events-list` that you can use in conjunction with this component. You'll want to ensure the desired route is enabled via the `events calendar categories` setting in the Calendar plugin settings. The block params use this [syntax](https://momentjs.com/docs/#/displaying/format/), for example `MMMM D, YYYY`. |
There was a problem hiding this comment.
This is neat to have in the readme. Other plugins/themes contribute blocks that can be used here, I can think of just Gamification off the top of my head, but I'm sure there are a few more. Probably documented on the meta topic.
There was a problem hiding this comment.
Oooh cool! Good to know.
pmusaraj
changed the title
Allows component to handle subcategories.
In order for this to work with
upcoming-events-list, you must add the subcategory to the Calendar plugin settings:(This started as a Sailpoint request, and from what I've seen on Meta it looks like others might utilize this as well.)