Making Single Tenant work for the Microsoft auth plugin. #67
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new setting to be able to add Tenant ID.
Added description for the new setting microsoft_auth_tenant_id.
Added setting for single tenant ID. Moved "client_option" from lib/omniauth-microsoft365.rb to this file.
Moved "client_option" to file ../plugins.rb.
Update version and name of plugin.
Update name , version and github address.
Corrected name and updated to a minor version change.
|
If you see something more that should be fixed before getting this approved. Please, just let me know and I will fix it. |
|
I'm just wondering. Is this kind of update not wanted? Would be good to get such clarification in the discourse topic if that is the case. Or shall I spend some time to resolve the conflict for a merge? |
|
I also have the same error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug, and making sure that single tenant is supported as well if using Microsoft for authentication.
https://meta.discourse.org/t/microsoft-authentication/51731/43