FEATURE: add topic tags changed trigger to chat integration #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add description on how to use the placeholder
Add tests to new method
If triggered when a topic tag is changed, message behavior will follow what user defined in message.
Added migration to handle the migration of the `tag_added` filter from the chat-integration plugin. Only removed the logic from the plugin, data removal will happen in a future PR
markvanlan
reviewed
Aug 13, 2024
| }) | ||
| channel.rules | ||
| .filter((rule) => { | ||
| return rule.filter !== "tag_added"; |
There was a problem hiding this comment.
I wonder if it'd be better to only allow from a list rather than blocking this one type specifically?
| # frozen_string_literal: true | ||
| class MigrateTagAddedFromFilterToAutomation < ActiveRecord::Migration[7.1] | ||
| def up | ||
| if defined?(DiscourseAutomation) && |
There was a problem hiding this comment.
I wonder if this entire logic should be wrapped in a begin/rescue b/c we don't really want this migration to FAIL if in the future, some of these classes change or something... It's risky to write migrations with logic referencing specific classes like this. Yeah I think rescueing errors would be good.
…t with available filters
markvanlan
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.