DEV: Bump rubocop-discourse to 3.8.0 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
bump_rubocop_discourse
branch
from
cad3d89
to
ec5aced
Compare
CvX
approved these changes
Nov 14, 2024
This commit resolves all `Lint/OrAssignmentToConstant` cop violations.
tgxworld
force-pushed
the
bump_rubocop_discourse
branch
from
ec5aced
to
b66f42f
Compare
tgxworld
commented
Nov 14, 2024
Comment on lines
-5
to
-17
| TIMEZONES_DEFINITIONS ||= | ||
| "https://raw.githubusercontent.com/moment/moment-timezone/develop/data/meta/latest.json" | ||
| UNUSED_REGIONS ||= %w[ | ||
| ecbtarget | ||
| federalreserve | ||
| federalreservebanks | ||
| fedex | ||
| nerc | ||
| unitednations | ||
| ups | ||
| nyse | ||
| ] | ||
| HOLIDAYS_COUNTRY_OVERRIDES ||= { "gr" => "el" } |
There was a problem hiding this comment.
@CvX Random fact that I discovered, rake files are loaded multiple times by rake for some reason so defining a global constant in a rake file will cause the constant redefinition warning to be raised.
There was a problem hiding this comment.
I keep rediscovering that every ~2 years 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves all
Lint/OrAssignmentToConstantcop violations.