FEATURE: allow event editors to control list of users on the event #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously event editors could remove people from an event but had no way of acting on behalf of users in the event and adding them. That meant that for events to properly show up in agenda and so on a user must actively click a button. In some cases (company ran events) the event manager may prefer controlling attendance.
SamSaffron
changed the title
CvX
reviewed
Oct 10, 2024
assets/javascripts/discourse/components/modal/post-event-invitees.gjs
Outdated
Show resolved
Hide resolved
| {{renderInvitee invitee}} | ||
| {{#if @model.event.can_act_on_discourse_post_event}} | ||
| <DButton | ||
| @icon="trash-alt" |
Comment on lines
109
to
116
| <Input | ||
| @value={{this.filter}} | ||
| {{on "input" this.onFilterChanged}} | ||
| class="filter" | ||
| placeholder={{i18n | ||
| "discourse_calendar.discourse_post_event.invitees_modal.filter_placeholder" | ||
| }} | ||
| /> |
There was a problem hiding this comment.
it's recommended to avoid Input component and use a native input element instead:
Suggested change
| <Input | |
| @value={{this.filter}} | |
| {{on "input" this.onFilterChanged}} | |
| class="filter" | |
| placeholder={{i18n | |
| "discourse_calendar.discourse_post_event.invitees_modal.filter_placeholder" | |
| }} | |
| /> | |
| <input | |
| {{on "input" this.onFilterChanged}} | |
| type="text" | |
| placeholder={{i18n | |
| "discourse_calendar.discourse_post_event.invitees_modal.filter_placeholder" | |
| }} | |
| class="filter" | |
| /> |
Comment on lines
55
to
58
| @debounce(250) | ||
| onFilterChanged() { | ||
| this._fetchInvitees(this.filter); | ||
| } |
There was a problem hiding this comment.
native input continued:
Suggested change
| @debounce(250) | |
| onFilterChanged() { | |
| this._fetchInvitees(this.filter); | |
| } | |
| @debounce(250) | |
| onFilterChanged(event) { | |
| this.filter = event.target.value; | |
| this._fetchInvitees(this.filter); | |
| } |
Co-authored-by: Jarek Radosz <[email protected]>
…ees.gjs Co-authored-by: Jarek Radosz <[email protected]>
|
@CvX all is handled and I added some system spec coverage |
CvX
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously event editors could remove people from an event but had no way
of acting on behalf of users in the event and adding them.
That meant that for events to properly show up in agenda and so on a user
must actively click a button.
In some cases (company ran events) the event manager may prefer controlling attendance.