UX: Allow event time to be hidden if desired #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato
reviewed
Sep 5, 2024
assets/javascripts/discourse/components/upcoming-events-list.gjs
Outdated
Show resolved
Hide resolved
|
It would also be nice to cover this "empty format" behavior in tests for both |
My local setup is suddenly not working, but once that's fixed, that's the plan :) |
brrusselburg
force-pushed
the
br/adjustments
branch
from
7c64478
to
94cc30d
Compare
brrusselburg
force-pushed
the
br/adjustments
branch
from
94cc30d
to
fdb4224
Compare
dbattersby
reviewed
Sep 10, 2024
test/javascripts/integration/components/upcoming-events-list-test.gjs
Outdated
Show resolved
Hide resolved
dbattersby
reviewed
Sep 10, 2024
test/javascripts/integration/components/upcoming-events-list-test.gjs
Outdated
Show resolved
Hide resolved
brrusselburg
force-pushed
the
br/adjustments
branch
from
13753d6
to
4748aad
Compare
CvX
reviewed
Sep 10, 2024
test/javascripts/integration/components/upcoming-events-list-test.gjs
Outdated
Show resolved
Hide resolved
CvX
approved these changes
Sep 10, 2024
…est.gjs Co-authored-by: Jarek Radosz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already the case for
monthFormat. A blanktimeFormatfield results in a neater-looking list, if desired: