Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Fix acceptance test #450

Merged
merged 1 commit into from
Oct 9, 2023
Merged

DEV: Fix acceptance test #450

merged 1 commit into from
Oct 9, 2023

Conversation

jancernik
Copy link
Member

No description provided.

CvX
CvX approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@CvX CvX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that core CI does pass with this change. Merging, thanks!

@CvX CvX changed the title WIP: Fix acceptance test DEV: Fix acceptance test Oct 9, 2023
@CvX CvX merged commit acba52f into discourse:main Oct 9, 2023
4 checks passed
@jancernik
Copy link
Member Author

Not sure what happened then, this was a random change to make a PR and test the GitHub actions. 🙃
I could never reproduce the issue

@CvX
Copy link
Contributor

CvX commented Oct 9, 2023

I'll keep an eye out on any further issues 😃

@CvX
Copy link
Contributor

CvX commented Oct 9, 2023

Well, that was quick - Dependabot PRs failed 🥲 investigating

@jancernik
Copy link
Member Author

😕 The difference from the other tests is that I stripped the fixture. But I'm not sure if that has anything to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jancernik @CvX