fix: memory leak in event triggers #1075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes:
The trigger creates a "trigger" function which saves the context into the _listeners map in the client.
Each time this function get's triggered the response is pushed into the responses array, which is created once, on startup. This causes a memory leak which saves all responses during the lifetime of the bot.
By moving the respones array into the function itself this is resolved and it will only return the responses for that specific trigger and the array can be garbage collected after this.
For a quick example of this bug on production (running for around a week with 100k members):
This array uses about 250 MB of memory, which is about 90% of all memory usage, and the array only contains empty objects returned from the execute function.