refactor: lint (#1032)

discordx-ts · Jun 11, 2024 · 97dd02c · 97dd02c
1 parent 9f4a77f
commit 97dd02c
Show file tree

Hide file tree

Showing 64 changed files with 570 additions and 548 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -1,7 +1,7 @@
 {
   "extends": [
     "eslint:recommended",
-    "plugin:@typescript-eslint/recommended-type-checked",
+    "plugin:@typescript-eslint/strict-type-checked",
     "plugin:@typescript-eslint/stylistic-type-checked",
     "plugin:prettier/recommended",
   ],
@@ -20,7 +20,12 @@
   ],
   "root": true,
   "rules": {
-    // disabled
+    // typescript-eslint
+    "@typescript-eslint/consistent-return": "error",
+    "@typescript-eslint/consistent-type-assertions": "error",
+    "@typescript-eslint/consistent-type-definitions": "error",
+    "@typescript-eslint/consistent-type-exports": "error",
+    "@typescript-eslint/consistent-type-imports": "error",
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-redundant-type-constituents": "off",
     "@typescript-eslint/no-unsafe-argument": "off",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -55,8 +55,8 @@
     "@changesets/cli": "^2.27.5",
     "@commitlint/cli": "^19.3.0",
     "@commitlint/config-angular": "^19.3.0",
-    "@typescript-eslint/eslint-plugin": "^7.12.0",
-    "@typescript-eslint/parser": "^7.12.0",
+    "@typescript-eslint/eslint-plugin": "^7.13.0",
+    "@typescript-eslint/parser": "^7.13.0",
     "eslint": "^8.57.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.29.1",
@@ -66,9 +66,9 @@
     "husky": "^9.0.11",
     "is-ci": "^3.0.1",
     "minipass": "^7.1.2",
-    "prettier": "^3.3.1",
+    "prettier": "^3.3.2",
     "tsup": "^8.1.0",
-    "turbo": "^2.0.1",
+    "turbo": "^2.0.3",
     "typedoc": "^0.25.13",
     "typescript": "5.4.5"
   },

diff --git a/packages/create-discordx/CHANGELOG.md b/packages/create-discordx/CHANGELOG.md
@@ -1,5 +1,11 @@
 # create-discordx
 
+## 1.2.2
+
+### Patch Changes
+
+- lint
+
 ## 1.2.1
 
 ### Patch Changes

diff --git a/packages/create-discordx/package.json b/packages/create-discordx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "create-discordx",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "create discordx apps with one command",
   "keywords": [
     "bot",

diff --git a/packages/create-discordx/src/helper/package-manager.ts b/packages/create-discordx/src/helper/package-manager.ts
@@ -17,7 +17,7 @@ export enum PackageManager {
 }
 
 export async function GetPackageManager(): Promise<PackageManager | null> {
-  const selected = await prompts<string>(
+  const selected = await prompts(
     {
       choices: [
         {

diff --git a/packages/create-discordx/src/helper/template.ts b/packages/create-discordx/src/helper/template.ts
@@ -53,15 +53,16 @@ export async function IsTemplateExist(name: string): Promise<boolean> {
 
 async function downloadTar(url: string) {
   const pipeline = promisify(Stream.pipeline);
-  const tempFile = join(tmpdir(), `discordx-template.temp-${Date.now()}`);
+  const tempFilename = `discordx-template.temp-${Date.now().toString()}`;
+  const tempFilePath = join(tmpdir(), tempFilename);
 
   const request = await axios({
     responseType: "stream",
     url: url,
   });
 
-  await pipeline(Readable.from(request.data), createWriteStream(tempFile));
-  return tempFile;
+  await pipeline(Readable.from(request.data), createWriteStream(tempFilePath));
+  return tempFilePath;
 }
 
 /**

diff --git a/packages/create-discordx/src/helper/updater.ts b/packages/create-discordx/src/helper/updater.ts
@@ -43,11 +43,10 @@ if (update) {
     ? "npm i -g create-discordx@latest"
     : "npm i create-discordx@latest";
 
-  const template = `Update available ${chalk.dim(
-    `${packageJson.version}`,
-  )}${chalk.reset(" → ")}${chalk.green(`${update.latest}`)} \nRun ${chalk.cyan(
-    updateCmd,
-  )} to update`;
+  const updateVersion = packageJson.version;
+  const updateLatest = update.latest;
+  const updateCommand = updateCmd;
+  const template = `Update available ${chalk.dim(updateVersion)}${chalk.reset(" → ")}${chalk.green(updateLatest)} \nRun ${chalk.cyan(updateCommand)} to update`;
 
   console.log(
     boxen(template, {

diff --git a/packages/create-discordx/src/index.ts b/packages/create-discordx/src/index.ts
@@ -36,7 +36,7 @@ console.log(`
   ██║  ██║██║╚════██║██║     ██║   ██║██╔══██╗██║  ██║ ██╔██╗ 
   ██████╔╝██║███████║╚██████╗╚██████╔╝██║  ██║██████╔╝██╔╝ ██╗
   ╚═════╝ ╚═╝╚══════╝ ╚═════╝ ╚═════╝ ╚═╝  ╚═╝╚═════╝ ╚═╝  ╚═╝
-  ${chalk.dim(`v${version}`)}
+  ${chalk.dim(`v${String(version)}`)}
 `);
 
 /**
@@ -95,7 +95,7 @@ if (!templateList.length) {
   process.exit();
 }
 
-const response = await prompts<string>(
+const response = await prompts(
   {
     choices: templateList,
     message: "Pick template",

diff --git a/packages/di/CHANGELOG.md b/packages/di/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @discordx/di
 
+## 3.3.1
+
+### Patch Changes
+
+- lint
+
 ## 3.3.0
 
 ### Minor Changes

diff --git a/packages/di/package.json b/packages/di/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@discordx/di",
-  "version": "3.3.0",
+  "version": "3.3.1",
   "private": false,
   "description": "dependency injection service with TSyringe support",
   "keywords": [

diff --git a/packages/di/src/index.ts b/packages/di/src/index.ts
@@ -30,6 +30,7 @@ export type InstanceOf<T> = T extends new (...args: unknown[]) => infer R
  *
  * @category Internal
  */
+// eslint-disable-next-line @typescript-eslint/no-extraneous-class
 export class DIService {
   private static _engine: IDependencyRegistryEngine =
     defaultDependencyRegistryEngine;

diff --git a/packages/di/src/logic/impl/DefaultDependencyRegistryEngine.ts b/packages/di/src/logic/impl/DefaultDependencyRegistryEngine.ts
@@ -10,7 +10,7 @@ import type { IDependencyRegistryEngine } from "../IDependencyRegistryEngine.js"
 export class DefaultDependencyRegistryEngine
   implements IDependencyRegistryEngine
 {
-  private static _instance: DefaultDependencyRegistryEngine;
+  private static _instance: DefaultDependencyRegistryEngine | undefined;
   private _services = new Map();
 
   public static get instance(): DefaultDependencyRegistryEngine {

diff --git a/packages/di/src/logic/impl/TsyringeDependencyRegistryEngine.ts b/packages/di/src/logic/impl/TsyringeDependencyRegistryEngine.ts
@@ -19,7 +19,7 @@ type Factory = <T>(factoryFunc: FactoryFunction<T>) => FactoryFunction<T>;
 export class TsyringeDependencyRegistryEngine extends AbstractConfigurableDependencyInjector<DependencyContainer> {
   public static token = Symbol("discordx");
 
-  private static _instance: TsyringeDependencyRegistryEngine;
+  private static _instance: TsyringeDependencyRegistryEngine | undefined;
 
   private factory: Factory | null = null;
 

diff --git a/packages/di/src/logic/impl/TypeDiDependencyRegistryEngine.ts b/packages/di/src/logic/impl/TypeDiDependencyRegistryEngine.ts
@@ -16,7 +16,7 @@ export class TypeDiDependencyRegistryEngine extends AbstractConfigurableDependen
 > {
   public static token = new Token<unknown>("discordx");
 
-  private static _instance: TypeDiDependencyRegistryEngine;
+  private static _instance: TypeDiDependencyRegistryEngine | undefined;
 
   private service: typeof Service | undefined;
 

diff --git a/packages/discordx/CHANGELOG.md b/packages/discordx/CHANGELOG.md
@@ -1,5 +1,15 @@
 # discordx
 
+## 11.9.4
+
+### Patch Changes
+
+- lint
+
+- Updated dependencies []:
+  - @discordx/internal@1.1.2
+  - @discordx/di@3.3.1
+
 ## 11.9.3
 
 ### Patch Changes

diff --git a/packages/discordx/package.json b/packages/discordx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "discordx",
-  "version": "11.9.3",
+  "version": "11.9.4",
   "private": false,
   "description": "Create a discord bot with TypeScript and Decorators!",
   "keywords": [
@@ -49,8 +49,8 @@
     "test": "jest --detectOpenHandles"
   },
   "dependencies": {
-    "@discordx/di": "^3.3.0",
-    "@discordx/internal": "^1.1.1",
+    "@discordx/di": "^3.3.1",
+    "@discordx/internal": "^1.1.2",
     "lodash": "^4.17.21",
     "tslib": "^2.6.3"
   },