refactor(discordx): remove plugin feature (#1044)

discordx-ts · Jun 15, 2024 · 0926c07 · 0926c07
1 parent 04a3ade
commit 0926c07
Show file tree

Hide file tree

Showing 27 changed files with 1,330 additions and 1,546 deletions.
diff --git a/docs/docs/discordx/basics/plugin.md b/docs/docs/discordx/basics/plugin.md
diff --git a/docs/sidebars.js b/docs/sidebars.js
@@ -62,7 +62,6 @@ module.exports = {
         "discordx/basics/debugging",
         "discordx/basics/dependency-injection",
         "discordx/basics/metadatastorage",
-        "discordx/basics/plugin",
         "discordx/basics/rest-args-of",
         "discordx/basics/sharding",
       ],

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/discordx/CHANGELOG.md b/packages/discordx/CHANGELOG.md
@@ -1,5 +1,11 @@
 # discordx
 
+## 11.10.0
+
+### Minor Changes
+
+- removed discordx plugin feature
+
 ## 11.9.4
 
 ### Patch Changes

diff --git a/packages/discordx/examples/plugin/main.ts b/packages/discordx/examples/plugin/main.ts
diff --git a/packages/discordx/examples/plugin/plugin/commands/help.ts b/packages/discordx/examples/plugin/plugin/commands/help.ts
diff --git a/packages/discordx/examples/plugin/plugin/plugin.ts b/packages/discordx/examples/plugin/plugin/plugin.ts
diff --git a/packages/discordx/examples/plugin/tsconfig.json b/packages/discordx/examples/plugin/tsconfig.json
diff --git a/packages/discordx/package.json b/packages/discordx/package.json
@@ -1,6 +1,6 @@
 {
   "name": "discordx",
-  "version": "11.9.4",
+  "version": "11.10.0",
   "private": false,
   "description": "Create a discord bot with TypeScript and Decorators!",
   "keywords": [

diff --git a/packages/discordx/src/Client.ts b/packages/discordx/src/Client.ts
@@ -54,7 +54,6 @@ import type {
   IPrefixResolver,
   ISimpleCommandByName,
   ITriggerEventData,
-  Plugin,
   SimpleCommandConfig,
 } from "./index.js";
 import {
@@ -78,13 +77,11 @@ import {
 export class Client extends ClientJS {
   private _botId: string;
   private _isBuilt = false;
-  private _isPluginsLoaded = false;
   private _prefix: IPrefixResolver;
   private _simpleCommandConfig?: SimpleCommandConfig;
   private _silent: boolean;
   private _listeners = new Map<string, EventListenerDetail[]>();
   private _botGuilds: IGuild[] = [];
-  private _plugins: Plugin[] = [];
   private _guards: GuardFunction[] = [];
   private logger: ILogger;
 
@@ -301,7 +298,6 @@ export class Client extends ClientJS {
   constructor(options: ClientOptions) {
     super(options);
 
-    this._plugins = options.plugins ?? [];
     this._silent = options.silent ?? true;
     this.guards = options.guards ?? [];
     this.botGuilds = options.botGuilds ?? [];
@@ -1426,18 +1422,6 @@ export class Client extends ClientJS {
     return this.instance.trigger(options)(params);
   }
 
-  /**
-   * Load plugins
-   */
-  async initPlugins(): Promise<void> {
-    if (this._isPluginsLoaded) {
-      return;
-    }
-
-    this._isPluginsLoaded = true;
-    await Promise.all(this._plugins.map((plugin) => plugin.init(this)));
-  }
-
   /**
    * Bind discordx events to client
    */
@@ -1501,9 +1485,6 @@ export class Client extends ClientJS {
 
     this._isBuilt = true;
 
-    // Load plugins
-    await this.initPlugins();
-
     // Build instance
     await this.instance.build();
 

diff --git a/packages/discordx/src/logic/index.ts b/packages/discordx/src/logic/index.ts
@@ -5,4 +5,3 @@
  * -------------------------------------------------------------------------------------------------------
  */
 export * from "./metadata/MetadataStorage.js";
-export * from "./plugin.js";
diff --git a/packages/discordx/src/logic/plugin.ts b/packages/discordx/src/logic/plugin.ts
diff --git a/packages/discordx/src/types/core/ClientOptions.ts b/packages/discordx/src/types/core/ClientOptions.ts
@@ -9,12 +9,7 @@ import type {
   Message,
 } from "discord.js";
 
-import type {
-  ArgSplitter,
-  GuardFunction,
-  IGuild,
-  Plugin,
-} from "../../index.js";
+import type { ArgSplitter, GuardFunction, IGuild } from "../../index.js";
 import type { Awaitable, ILogger, IPrefixResolver } from "../index.js";
 
 export interface SimpleCommandConfig {
@@ -60,11 +55,6 @@ export interface ClientOptions extends DiscordJSClientOptions {
    */
   logger?: ILogger;
 
-  /**
-   * Set of plugins
-   */
-  plugins?: Plugin[];
-
   /**
    * Do not log anything
    */

diff --git a/packages/plugin-lava-player/CHANGELOG.md b/packages/plugin-lava-player/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @discordx/plugin-lava-player
 
+## 2.2.0
+
+### Minor Changes
+
+- removed discordx plugin feature
+
 ## 2.1.3
 
 ### Patch Changes

diff --git a/packages/plugin-lava-player/README.md b/packages/plugin-lava-player/README.md
@@ -44,8 +44,6 @@ lava player plugin for discordx bots.
 
 ```
 npm install @discordx/plugin-lava-player
-yarn add @discordx/plugin-lava-player
-pnpm add @discordx/plugin-lava-player
 ```
 
 # ⚠️ Prerequisites
@@ -60,14 +58,7 @@ To use this plugin, You will need to have a running Lavalink instance as well as
 # 📄 Usage
 
 ```ts
-import { Client, MetadataStorage } from "discordx";
-import { LavaPlayerPlugin } from "@discordx/plugin-lava-player";
-
-// Initialize the Plugin:
-const lavaPlugin = new LavaPlayerPlugin({ metadata: MetadataStorage.instance });
-
-// Provide the plugin to the Discordx Client:
-const client = new Client({ plugins: [lavaPlugin] });
+import "@discordx/plugin-lava-player";
 ```
 
 # 📜 Documentation