-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Message#bulkDeletable
#8760
feat: add Message#bulkDeletable
#8760
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is missing direct message channel checks.
Also, if possible, can you state a use case for this as the bulk delete method we have already filters out ids that cannot be bulk deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as with #8761 (review), I'll approve once those requests are resolved on both PRs.
Codecov Report
@@ Coverage Diff @@
## main #8760 +/- ##
==========================================
+ Coverage 85.22% 85.46% +0.23%
==========================================
Files 77 90 +13
Lines 6715 9363 +2648
Branches 877 1117 +240
==========================================
+ Hits 5723 8002 +2279
- Misses 953 1319 +366
- Partials 39 42 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please describe the changes this PR makes and why it should be merged:
This PR adds
Message#bulkDeletable
Status and versioning classification: