Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): use dropdowns for overloads #8630

Merged

Conversation

suneettipirneni
Copy link
Member

I'll reduce code duplication in a followup.

@vercel
Copy link

vercel bot commented Sep 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Sep 17, 2022 at 0:09AM (UTC)

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #8630 (1b18451) into main (1d72663) will increase coverage by 7.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8630      +/-   ##
==========================================
+ Coverage   79.05%   86.50%   +7.45%     
==========================================
  Files          48       87      +39     
  Lines        5585     8672    +3087     
  Branches      700     1110     +410     
==========================================
+ Hits         4415     7502    +3087     
  Misses       1128     1128              
  Partials       42       42              
Flag Coverage Δ
builders 100.00% <ø> (?)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.86% <ø> (ø)
ws 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ionCommandOptionWithChoicesAndAutocompleteMixin.ts 100.00% <0.00%> (ø)
.../src/interactions/slashCommands/options/boolean.ts 100.00% <0.00%> (ø)
.../interactions/slashCommands/options/mentionable.ts 100.00% <0.00%> (ø)
.../src/interactions/slashCommands/options/channel.ts 100.00% <0.00%> (ø)
...ixins/ApplicationCommandOptionChannelTypesMixin.ts 100.00% <0.00%> (ø)
...ApplicationCommandNumericOptionMinMaxValueMixin.ts 100.00% <0.00%> (ø)
...s/src/interactions/slashCommands/options/number.ts 100.00% <0.00%> (ø)
...es/builders/src/components/textInput/Assertions.ts 100.00% <0.00%> (ø)
...actions/slashCommands/mixins/NameAndDescription.ts 100.00% <0.00%> (ø)
.../src/interactions/slashCommands/options/integer.ts 100.00% <0.00%> (ø)
... and 29 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel vercel bot temporarily deployed to Preview September 17, 2022 02:08 Inactive
@vercel vercel bot temporarily deployed to Preview September 17, 2022 04:45 Inactive
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
only 1st overload is showing code highlight

@suneettipirneni
Copy link
Member Author

image only 1st overload is showing code highlight

This seems to be an issue outside the scope of this PR as it happens on the live website as well.

@vercel vercel bot temporarily deployed to Preview September 17, 2022 12:09 Inactive
@iCrawl iCrawl merged commit 678ceaa into discordjs:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants