Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ThreadChannel): better property handling #6172

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jul 22, 2021

Please describe the changes this PR makes and why it should be merged:

Sets thread auto archive to 0 when not sent in a paylod (exception for interactions)

closes: #6151

Also Fixes docs and typings for ThreadChannels

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@iCrawl iCrawl added this to the Version 13 milestone Jul 22, 2021
src/managers/ChannelManager.js Outdated Show resolved Hide resolved
src/structures/ThreadChannel.js Show resolved Hide resolved
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @vladfrangu's comments, this looks good to me.

@ckohen ckohen changed the title fix(ThreadChannel): set thread slowmode to 0 when not sent fix(ThreadChannel): better property handling Jul 27, 2021
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're sure this change to _add is handled everywhere, LGTM.

@iCrawl iCrawl merged commit 9679b90 into discordjs:master Jul 28, 2021
@ckohen ckohen deleted the fix-thread-slow branch July 28, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with the (threadUpdate) event.
6 participants