Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Instance#fetch force true by default, and fix force parameter #6116

Merged
merged 4 commits into from
Jul 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/structures/Channel.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@ class Channel extends Base {

/**
* Fetches this channel.
* @param {boolean} [force=false] Whether to skip the cache check and request the API
* @param {boolean} [force=true] Whether to skip the cache check and request the API
* @returns {Promise<Channel>}
*/
fetch(force = false) {
return this.client.channels.fetch(this.id, true, force);
fetch(force = true) {
return this.client.channels.fetch(this.id, { force });
}

/**
Expand Down
4 changes: 2 additions & 2 deletions src/structures/DMChannel.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ class DMChannel extends Channel {

/**
* Fetch this DMChannel.
* @param {boolean} [force=false] Whether to skip the cache check and request the API
* @param {boolean} [force=true] Whether to skip the cache check and request the API
* @returns {Promise<DMChannel>}
*/
fetch(force = false) {
fetch(force = true) {
return this.recipient.createDM(force);
}

Expand Down
4 changes: 2 additions & 2 deletions src/structures/GuildBan.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ class GuildBan extends Base {

/**
* Fetches this GuildBan.
* @param {boolean} [force=false] Whether to skip the cache check and request the API
* @param {boolean} [force=true] Whether to skip the cache check and request the API
* @returns {Promise<GuildBan>}
*/
fetch(force = false) {
fetch(force = true) {
return this.guild.bans.fetch({ user: this.user, cache: true, force });
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/structures/GuildMember.js
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,10 @@ class GuildMember extends Base {

/**
* Fetches this GuildMember.
* @param {boolean} [force=false] Whether to skip the cache check and request the API
* @param {boolean} [force=true] Whether to skip the cache check and request the API
* @returns {Promise<GuildMember>}
*/
fetch(force = false) {
fetch(force = true) {
return this.guild.members.fetch({ user: this.id, cache: true, force });
}

Expand Down
6 changes: 3 additions & 3 deletions src/structures/Message.js
Original file line number Diff line number Diff line change
Expand Up @@ -721,11 +721,11 @@ class Message extends Base {

/**
* Fetch this message.
* @param {boolean} [force=false] Whether to skip the cache check and request the API
* @param {boolean} [force=true] Whether to skip the cache check and request the API
* @returns {Promise<Message>}
*/
fetch(force = false) {
return this.channel.messages.fetch(this.id, true, force);
fetch(force = true) {
return this.channel.messages.fetch(this.id, { force });
}

/**
Expand Down
6 changes: 3 additions & 3 deletions src/structures/User.js
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,11 @@ class User extends Base {

/**
* Fetches this user.
* @param {boolean} [force=false] Whether to skip the cache check and request the API
* @param {boolean} [force=true] Whether to skip the cache check and request the API
* @returns {Promise<User>}
*/
fetch(force = false) {
return this.client.users.fetch(this.id, true, force);
fetch(force = true) {
return this.client.users.fetch(this.id, { force });
}

/**
Expand Down