Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Channel): add isThread typeguard for better TS support #5978

Merged
merged 2 commits into from
Jun 30, 2021
Merged

feat(Channel): add isThread typeguard for better TS support #5978

merged 2 commits into from
Jun 30, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Jun 30, 2021

Please describe the changes this PR makes and why it should be merged:

This PR adds Channel#isThread method to help TS users narrow down a generic channel into a ThreadChannel

Status and versioning classification:

  • Code changes have been tested against the Discord API
  • I know how to update typings and have done so
  • This PR changes the library's interface (method added)

ckohen
ckohen reviewed Jun 30, 2021
View reviewed changes
src/structures/Channel.js Outdated Show resolved Hide resolved
@iCrawl iCrawl added this to the Version 13 milestone Jun 30, 2021
@iCrawl iCrawl merged commit b7ed675 into discordjs:master Jun 30, 2021
@iShibi iShibi deleted the feat-is-thread branch August 14, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckohen ckohen ckohen left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
5 participants
@iShibi @ckohen @vladfrangu @iCrawl @kyranet