Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Interactions): auto-fetch replies where possible #5830

Closed
wants to merge 2 commits into from

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Jun 12, 2021

Stemming from internal discussion, this is one of two opposing PRs which provide a way to automatically fetch the reply/deferral/update to an interaction, assuming it's not ephemeral.

This PR does the fetching automatically no matter what, returning a Promise<Message> where possible.

Note: I had to return undefined manually here instead of the blank return due to linting, unsure if this matters or if this still counts as void.

(Testing cross-PR closing) - Closes #5831

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@vladfrangu
Copy link
Member

This also needs a rebase

@iCrawl
Copy link
Member

iCrawl commented Jun 24, 2021

This needs a rebase.

@iCrawl
Copy link
Member

iCrawl commented Jun 24, 2021

We will most likely (if at all) move forward with the other implementation in #5831

@iCrawl iCrawl closed this Jun 24, 2021
@monbrey monbrey deleted the interaction-autofetch branch June 24, 2021 21:35
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants