Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisified single interaction collection #5770

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Jun 6, 2021

Putting this one up here for discussion.

Conceptually, I don't think collecting multiple interactions with the promisified Message#awaitMessageComponentInteractions made any sense, since all interactions need to be responded to within 3 seconds.
Instead, I've modified the function to singular, taking only a time option (in addition to the filter).
The Promise resolves to a MessageComponentInteraction if one passes the filter, or rejects if the time runs out.

Status and versioning classification:

  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl merged commit c2b3ed0 into discordjs:master Jun 8, 2021
@monbrey monbrey deleted the await-interaction branch June 9, 2021 11:38
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants