Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Typings): add missing typings for HttpError -> requestData #5742

Merged
merged 9 commits into from
Jun 3, 2021
Merged

fix(Typings): add missing typings for HttpError -> requestData #5742

merged 9 commits into from
Jun 3, 2021

Conversation

casperiv0
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

This PR adds missing typings from #5701

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so

SpaceEEC
SpaceEEC reviewed Jun 3, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
vladfrangu
vladfrangu previously requested changes Jun 3, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructors need to be updated

@casperiv0
Copy link
Contributor Author

casperiv0 commented Jun 3, 2021 •
edited
Loading

The constructors need to be updated

Is there any request type or should I create one? @vladfrangu nvm

@casperiv0
Copy link
Contributor Author

The constructors need to be updated

Done

@iCrawl iCrawl requested a review from vladfrangu June 3, 2021 15:03
SpaceEEC
SpaceEEC requested changes Jun 3, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
casperiv0
casperiv0 commented Jun 3, 2021
View reviewed changes
src/rest/HTTPError.js Outdated Show resolved Hide resolved
SpaceEEC
SpaceEEC approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

@iCrawl iCrawl merged commit 3e9ce35 into discordjs:master Jun 3, 2021
@casperiv0 casperiv0 deleted the fix/add-missing-typings branch June 3, 2021 18:25
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
5 participants
@casperiv0 @vladfrangu @iCrawl @kyranet @SpaceEEC