Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BitField): throw an error if bit to resolve is undefined #5565

Merged
merged 9 commits into from
Jun 9, 2021
Merged

fix(BitField): throw an error if bit to resolve is undefined #5565

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
83374bd
fix(Bitfield): has must return false it bit is undefined
kevinbioj Apr 28, 2021
41285af
Update src/util/BitField.js
kevinbioj Apr 30, 2021
1e3c8ca
fix(BitField): throw an error if bit to resolve is undefined
kevinbioj May 7, 2021
39bd4f0
fix(BitField): keep consistency for recursive has calls
kevinbioj May 7, 2021
e2f343b
typings(BitField): ...hasParam for has
kevinbioj May 7, 2021
ae896e6
fix(Permissions): pass checkAdmin to BitField#has
kevinbioj May 7, 2021
d31c779
revert(Permissions): revert to default behavior
kevinbioj Jun 9, 2021
3a2db52
revert(BitField): revert changes + fix(BitField): letting resolve han…
kevinbioj Jun 9, 2021
6b994a9
revert(typings): revert changes
kevinbioj Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/util/BitField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class BitField {
* @returns {boolean}
*/
has(bit) {
if (Array.isArray(bit)) return bit.every(p => this.has(p));
bit = this.constructor.resolve(bit);
return (this.bitfield & bit) === bit;
}
Expand Down Expand Up @@ -143,7 +142,6 @@ class BitField {
*/
static resolve(bit) {
const { defaultBit } = this;
if (typeof bit === 'undefined') return defaultBit;
if (typeof defaultBit === typeof bit && bit >= defaultBit) return bit;
if (bit instanceof BitField) return bit.bitfield;
if (Array.isArray(bit)) return bit.map(p => this.resolve(p)).reduce((prev, p) => prev | p, defaultBit);
Expand Down