Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ShardingManager): client error event cannot be emitted #5559

Merged
merged 4 commits into from
Jun 7, 2021
Merged

fix(ShardingManager): client error event cannot be emitted #5559

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0635cf
Update ShardClientUtil.js
meister03 Apr 23, 2021
1dc50e7
Update src/sharding/ShardClientUtil.js
meister03 Apr 24, 2021
5e78df0
Update src/sharding/ShardClientUtil.js
meister03 Apr 25, 2021
896b742
Update src/sharding/ShardClientUtil.js
meister03 Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sharding/ShardClientUtil.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,13 @@ class ShardClientUtil {
*/
_respond(type, message) {
this.send(message).catch(err => {
err.message = `Error when sending ${type} response to master process: ${err.message}`;
const error = new Error(`Error when sending ${type} response to master process: ${err.message}`);
meister03 marked this conversation as resolved.
Show resolved Hide resolved
/**
* Emitted when the client encounters an error.
* @event Client#error
* @param {Error} error The error encountered
*/
this.client.emit(Events.ERROR, err);
this.client.emit(Events.ERROR, error);
});
}

Expand Down