fix(WebSocketShard): key name in WebSocketShard#_send. #5304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just changed an incorrect key name that was introduced in Pull Request discordjs#3722. When destroying the websocket from the WebSocketShard#_send method it's using `close` as the key name instead of `closeCode`
vladfrangu
approved these changes
Feb 8, 2021
kyranet
approved these changes
Feb 8, 2021
What about re-writing Discord.js in v14 after #5106 get's merged |
iCrawl
approved these changes
Feb 10, 2021
No. |
iCrawl
changed the title
Using TypeScript would really benefit the project. Static Type definitions and everything that makes JavaScript better and secure. We will get enums which will help a lot. |
|
A TypeScript rewrite is planned in a separate repository, it is not versioned yet, so no, v14 will very likely not be the rewrite. Please stop discussing this in a completely unrelated issue, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I just changed an incorrect key name that was introduced in Pull Request #3722. When destroying the websocket from the WebSocketShard#_send method it's using
closeas the key name instead ofcloseCode. This was just a small thing that I noticed while going through the files and I did a little bit of testing before I made this pr and it didn't break or solve anything that I know of.Status and versioning classification: