Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ReactionUserManager): remove before query option #5281

Merged
merged 1 commit into from
Mar 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/managers/ReactionUserManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,14 @@ class ReactionUserManager extends BaseManager {
* Fetches all the users that gave this reaction. Resolves with a collection of users, mapped by their IDs.
* @param {Object} [options] Options for fetching the users
* @param {number} [options.limit=100] The maximum amount of users to fetch, defaults to 100
* @param {Snowflake} [options.before] Limit fetching users to those with an id lower than the supplied id
* @param {Snowflake} [options.after] Limit fetching users to those with an id greater than the supplied id
* @returns {Promise<Collection<Snowflake, User>>}
*/
async fetch({ limit = 100, after, before } = {}) {
async fetch({ limit = 100, after } = {}) {
const message = this.reaction.message;
const data = await this.client.api.channels[message.channel.id].messages[message.id].reactions[
this.reaction.emoji.identifier
].get({ query: { limit, before, after } });
].get({ query: { limit, after } });
const users = new Collection();
for (const rawUser of data) {
const user = this.client.users.add(rawUser);
Expand Down
6 changes: 1 addition & 5 deletions typings/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2004,11 +2004,7 @@ declare module 'discord.js' {
export class ReactionUserManager extends BaseManager<Snowflake, User, UserResolvable> {
constructor(client: Client, iterable: Iterable<any> | undefined, reaction: MessageReaction);
public reaction: MessageReaction;
public fetch(options?: {
limit?: number;
after?: Snowflake;
before?: Snowflake;
}): Promise<Collection<Snowflake, User>>;
public fetch(options?: { limit?: number; after?: Snowflake }): Promise<Collection<Snowflake, User>>;
public remove(user?: UserResolvable): Promise<MessageReaction>;
}

Expand Down