Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Message): update getters to take null permissions into account #5066

Merged
merged 8 commits into from
Jan 22, 2021
Merged

fix(Message): update getters to take null permissions into account #5066

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fad9542
fix(Message): update message#delete
Dec 1, 2020
1d33351
refactor(Message): message#deletable avoid duplicate call
Dec 2, 2020
e8bc6d0
Update Message.js
zaida04 Dec 10, 2020
44f056e
fix(message): resolve syntax errors
zaida04 Dec 10, 2020
206c4b9
chore(message): resolve linting issues (death to the gh web panel)
zaida04 Dec 10, 2020
66ed226
Update Message.js
zaida04 Dec 13, 2020
2940bb5
death to the github web panel
Dec 13, 2020
7379ce9
Update src/structures/Message.js
zaida04 Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/structures/Message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,10 +406,10 @@ class Message extends Base {
* @readonly
*/
get deletable() {
return (
return Boolean(
!this.deleted &&
(this.author.id === this.client.user.id ||
(this.guild && this.channel.permissionsFor(this.client.user).has(Permissions.FLAGS.MANAGE_MESSAGES, false)))
(this.author.id === this.client.user.id ||
(this.guild && this.channel.permissionsFor(this.client.user)?.has(Permissions.FLAGS.MANAGE_MESSAGES, false))),
zaida04 marked this conversation as resolved.
Show resolved Hide resolved
);
}

Expand Down