-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switch api and gateway to V8 #4879
Conversation
imo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reflecting the second point in #4879 (comment).
sorry that took so long, but resolved in 9db4acc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will need extensive testing before merging 🙏
Some nitpicks for now
ok! i've done a quick test and everything seems to be working fine now, if anyone else wants to confirm that feel free, marking as ready for review ig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not ready. There are REST changes that need to be done to account for the ratelimits finally respecting specs...
@NotSugden this needs a rebase |
@iCrawl done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next to that, should options.intents
really be required? (i.e. WebhookClient
s, i don't know if those actually use intents)
i have made a new type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 2901 in 3e11c3b
interface PermissionFlags extends Record<PermissionString, number> {} |
needs to be updated to
interface PermissionFlags extends Record<PermissionString, bigint> {}
rebased & suggested changes applied |
fixed the docs error 🎉 |
As a note for maintainers, however, please make sure this PR has been tested across everything it modifies before merging 🙏 |
I have tested message create, react, edit, and delete rate limits on @NotSugden's branch and had no problems :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
discordjs/discord.js#4879 requires intents option
This reverts commit ee5bc1a.
you can fix it by enabling the CHANNEL partial; we should make that always on (should have been in this pr) |
Co-authored-by: Antonio Román <[email protected]>
Please describe the changes this PR makes and why it should be merged:
resolves #4669
V8 diff - discord/discord-api-docs@545ff4a
Changes currently in this PR:
BigInts
andPermissions
to use themchannelCreate
event emitting for DM Channels as that behaviour seems to have been removedchannelDelete
still emits, so that's been left as-isGuildMember
with thePresence Update
event as the roles are no longer sentClientUser#edit
Guild#embed*
in favour ofGuild#widget*
OverwriteTypes
constant to match API ChangeClientOptions#ws#intents
and replaced it withClientOptions#intents
, and made it required as the V8 Gateway requires themGuild#fetchIntegrations()
as the query parameter was removed in V8 (Add v8 integration changes to changelog discord/discord-api-docs#2238)GuildChannel#updateOverwrite()
asyncPermissionOverwrites#update()
asyncPermissionOverwrites#delete()
asyncNotes about the non-usage of BigInt literals
The usage of BigInt Litertals is due to a bug with the library handling the jsdoc, failing the CIStatus
Semantic versioning classification: